Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-868] [Bug] Remove unused mypy ignore #883

Closed
2 tasks done
Fokko opened this issue Aug 31, 2023 · 1 comment
Closed
2 tasks done

[ADAP-868] [Bug] Remove unused mypy ignore #883

Fokko opened this issue Aug 31, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Fokko
Copy link
Contributor

Fokko commented Aug 31, 2023

Is this a new bug in dbt-spark?

  • I believe this is a new bug in dbt-spark
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Mypy is complaining

Expected Behavior

Happy mypy

Steps To Reproduce

Run pre-commit with mypy

Relevant log output

check yaml...............................................................Passed
check json...........................................(no files to check)Skipped
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check for case conflicts.................................................Passed
black....................................................................Passed
flake8...................................................................Passed
mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

dbt/adapters/spark/column.py:12: error: Unused "type: ignore" comment  [unused-ignore]
Found 1 error in 1 file (checked 8 source files)

Environment

- OS:
- Python:
- dbt-core:
- dbt-spark:

Additional Context

No response

@Fokko Fokko added bug Something isn't working triage labels Aug 31, 2023
@github-actions github-actions bot changed the title [Bug] Remove unused mypy ignore [ADAP-868] [Bug] Remove unused mypy ignore Aug 31, 2023
@Fokko Fokko mentioned this issue Aug 31, 2023
4 tasks
@dataders
Copy link
Contributor

dataders commented Sep 6, 2023

resolved by: #880

@dataders dataders closed this as completed Sep 6, 2023
@jtcohen6 jtcohen6 removed the triage label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants