From 983725fe32368969770e2ed5eb44178e69aa43e6 Mon Sep 17 00:00:00 2001 From: Gerda Shank Date: Tue, 8 Oct 2024 18:04:42 -0400 Subject: [PATCH 1/3] Add tests to test_simple_snapshot.py --- dev-requirements.txt | 6 ++--- .../adapter/test_simple_snapshot.py | 23 +++++++++++++++++++ 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/dev-requirements.txt b/dev-requirements.txt index f3d120eec..53a6a404d 100644 --- a/dev-requirements.txt +++ b/dev-requirements.txt @@ -1,7 +1,7 @@ # install latest changes in dbt-core -git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core -git+https://github.com/dbt-labs/dbt-adapters.git -git+https://github.com/dbt-labs/dbt-adapters.git#subdirectory=dbt-tests-adapter +git+https://github.com/dbt-labs/dbt-core.git@snapshot_dbt_valid_to_current#egg=dbt-core&subdirectory=core +git+https://github.com/dbt-labs/dbt-adapters.git@test_various_snapshot_configs +git+https://github.com/dbt-labs/dbt-adapters.git@test_various_snapshot_configs#subdirectory=dbt-tests-adapter git+https://github.com/dbt-labs/dbt-common.git # dev diff --git a/tests/functional/adapter/test_simple_snapshot.py b/tests/functional/adapter/test_simple_snapshot.py index 4db5b2330..7952830bc 100644 --- a/tests/functional/adapter/test_simple_snapshot.py +++ b/tests/functional/adapter/test_simple_snapshot.py @@ -1,5 +1,12 @@ from dbt.tests.adapter.simple_snapshot.test_snapshot import BaseSnapshotCheck, BaseSimpleSnapshot +from dbt.test.adapter.simple_snapshot.test_various_snapshot_configs import ( + BaseSnapshotColumnNames, + BaseSnapshotColumnNamesFromDbtProject, + BaseSnapshotInvalidColumnNames, + BaseSnapshotDbtValidToCurrent, +) + class TestSnapshot(BaseSimpleSnapshot): pass @@ -7,3 +14,19 @@ class TestSnapshot(BaseSimpleSnapshot): class TestSnapshotCheck(BaseSnapshotCheck): pass + + +class TestSnapshotColumnNames(BaseSnapshotColumnNames): + pass + + +class TestSnapshotColumnNamesFromDbtProject(BaseSnapshotColumnNamesFromDbtProject): + pass + + +class TestSnapshotInvalidColumnNames(BaseSnapshotInvalidColumnNames): + pass + + +class TestSnapshotDbtValidToCurrent(BaseSnapshotDbtValidToCurrent): + pass From 1b5b1c56bee1c74d0c5671cb7d6d27fbc9d139fa Mon Sep 17 00:00:00 2001 From: Gerda Shank Date: Tue, 8 Oct 2024 18:24:03 -0400 Subject: [PATCH 2/3] typo --- tests/functional/adapter/test_simple_snapshot.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional/adapter/test_simple_snapshot.py b/tests/functional/adapter/test_simple_snapshot.py index 7952830bc..44bc4726f 100644 --- a/tests/functional/adapter/test_simple_snapshot.py +++ b/tests/functional/adapter/test_simple_snapshot.py @@ -1,6 +1,6 @@ from dbt.tests.adapter.simple_snapshot.test_snapshot import BaseSnapshotCheck, BaseSimpleSnapshot -from dbt.test.adapter.simple_snapshot.test_various_snapshot_configs import ( +from dbt.tests.adapter.simple_snapshot.test_various_snapshot_configs import ( BaseSnapshotColumnNames, BaseSnapshotColumnNamesFromDbtProject, BaseSnapshotInvalidColumnNames, From 2c0eb6ac2b8e4c2832fff2a0e21b7b0f6e5d9f15 Mon Sep 17 00:00:00 2001 From: Gerda Shank Date: Tue, 8 Oct 2024 19:42:02 -0400 Subject: [PATCH 3/3] Another typo --- tests/functional/adapter/test_simple_snapshot.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional/adapter/test_simple_snapshot.py b/tests/functional/adapter/test_simple_snapshot.py index 44bc4726f..660678a99 100644 --- a/tests/functional/adapter/test_simple_snapshot.py +++ b/tests/functional/adapter/test_simple_snapshot.py @@ -1,6 +1,6 @@ from dbt.tests.adapter.simple_snapshot.test_snapshot import BaseSnapshotCheck, BaseSimpleSnapshot -from dbt.tests.adapter.simple_snapshot.test_various_snapshot_configs import ( +from dbt.tests.adapter.simple_snapshot.test_various_configs import ( BaseSnapshotColumnNames, BaseSnapshotColumnNamesFromDbtProject, BaseSnapshotInvalidColumnNames,