Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-886] [Feature] Redact raw data from Duplicate Field Key Error #772

Closed
3 tasks done
jaypeedevlin opened this issue Sep 14, 2023 · 1 comment · Fixed by #773
Closed
3 tasks done

[ADAP-886] [Feature] Redact raw data from Duplicate Field Key Error #772

jaypeedevlin opened this issue Sep 14, 2023 · 1 comment · Fixed by #773
Labels
enhancement New feature or request

Comments

@jaypeedevlin
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-snowflake functionality, rather than a Big Idea better suited to a discussion

Describe the feature

In #378, redaction was added for duplicate row DML. We have recently discovered a second type of error — duplicate field key — which can leak sensitive data into logs. Here's an example of what an error looks like:

Duplicate field key 'my raw string goes here'

I'd like to propose adding similar redacting to this use case. I've also contact Snowflake to confirm whether there are other related errors we may need to handle.

Describe alternatives you've considered

Wrap dbt and redact the logs before they hit downstream alerting tools.

Who will this benefit?

Anyone wanting to stop data leaking into their logs.

Are you interested in contributing this feature?

Absolutely

Anything else?

No response

@jaypeedevlin jaypeedevlin added enhancement New feature or request triage labels Sep 14, 2023
@github-actions github-actions bot changed the title [Feature] Redact raw data from Duplicate Field Key Error [ADAP-886] [Feature] Redact raw data from Duplicate Field Key Error Sep 14, 2023
@dbeatty10 dbeatty10 removed the triage label Sep 14, 2023
@dbeatty10
Copy link
Contributor

Thanks for creating this issue and raising a PR @jaypeedevlin 🏆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants