Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-875] [Feature] Don't run insert/delete for incremental models when no data has been changed #761

Closed
3 tasks done
joshuataylor opened this issue Sep 7, 2023 · 2 comments

Comments

@joshuataylor
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-snowflake functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Not sure if this should be in the main dbt-core repository, but it would be really nice if when running the delete/insert it would check if temporary __dbt_tmp table had rows, and if not it would skip the insert/delete step.

This would not work well for views, as it might be expensive to operate on them.

Describe alternatives you've considered

Just living with it.

Who will this benefit?

Users of the incremental builds with Snowflake with large tables.

Are you interested in contributing this feature?

yes

Anything else?

No response

@joshuataylor joshuataylor added enhancement New feature or request triage labels Sep 7, 2023
@github-actions github-actions bot changed the title [Feature] Don't run insert/delete for incremental models when no data has been changed [ADAP-875] [Feature] Don't run insert/delete for incremental models when no data has been changed Sep 7, 2023
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 18, 2024
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants