From a5b39dfb3802dadb31697c79b36aa6c7914f73c8 Mon Sep 17 00:00:00 2001 From: VersusFacit <67295367+VersusFacit@users.noreply.github.com> Date: Tue, 5 Nov 2024 17:33:13 -0800 Subject: [PATCH] edit comments. --- dbt/include/snowflake/macros/adapters.sql | 3 --- .../adapter/list_relations_tests/test_show_objects.py | 10 +++++++--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/dbt/include/snowflake/macros/adapters.sql b/dbt/include/snowflake/macros/adapters.sql index da1f93877..0ca756c6c 100644 --- a/dbt/include/snowflake/macros/adapters.sql +++ b/dbt/include/snowflake/macros/adapters.sql @@ -135,9 +135,6 @@ {% endmacro %} {% macro snowflake__list_relations_without_caching(schema_relation, max_iter=10, max_results_per_iter=10000) %} - {# -- Use query_pre_hook for optional configurations prior to fetching relations. For sake of - -- consistent use, place ;s in the query_pre_hook definition, not this macro. #} - {%- set max_total_results = max_results_per_iter * max_iter -%} {%- set sql -%} {% if schema_relation is string %} diff --git a/tests/functional/adapter/list_relations_tests/test_show_objects.py b/tests/functional/adapter/list_relations_tests/test_show_objects.py index a167874d3..91fb94f79 100644 --- a/tests/functional/adapter/list_relations_tests/test_show_objects.py +++ b/tests/functional/adapter/list_relations_tests/test_show_objects.py @@ -115,9 +115,13 @@ def models(self): return {"my_model.sql": _MODEL_ICEBERG} def test_quoting_ignore_flag_doesnt_break_iceberg_metadata(self, project): - """We inject the QUOTED_IDENTIFIERS_IGNORE_CASE into the underlying query that fetches - objects which will fail without proper normalization within the python function after - the list relations macro returns.""" + """https://github.com/dbt-labs/dbt-snowflake/issues/1227 + + The list relations function involves a metadata sub-query. Regardless of + QUOTED_IDENTIFIERS_IGNORE_CASE, this function will fail without proper + normalization within the encapsulating python function after the macro invocation + returns. This test verifies that normalization is working. + """ run_dbt(["run"]) self.list_relations_without_caching(project)