From 3d8b8463a4631fdb2a152716ded612db6656fc42 Mon Sep 17 00:00:00 2001 From: Josh Devlin Date: Fri, 15 Sep 2023 09:09:50 +1000 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> --- dbt/adapters/snowflake/connections.py | 2 +- .../test_duplicate_key_not_in_exceptions.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dbt/adapters/snowflake/connections.py b/dbt/adapters/snowflake/connections.py index 04ca33c30..e324411cd 100644 --- a/dbt/adapters/snowflake/connections.py +++ b/dbt/adapters/snowflake/connections.py @@ -51,7 +51,7 @@ ERROR_REDACTION_PATTERNS = { "Row Values: [redacted]": re.compile(r"Row Values: \[(.|\n)*\]"), - "Duplicate field key '[redacted]'": re.compile(r"Duplicate field key '(.|\n)*'") + "Duplicate field key '[redacted]'": re.compile(r"Duplicate field key '(.|\n)*'"), } diff --git a/tests/functional/duplicate_key_unlogged/test_duplicate_key_not_in_exceptions.py b/tests/functional/duplicate_key_unlogged/test_duplicate_key_not_in_exceptions.py index bc525b979..83dd3b2c5 100644 --- a/tests/functional/duplicate_key_unlogged/test_duplicate_key_not_in_exceptions.py +++ b/tests/functional/duplicate_key_unlogged/test_duplicate_key_not_in_exceptions.py @@ -27,6 +27,6 @@ def models(self): return {"model.sql": _MODELS__view} def test_row_values_were_scrubbed_from_duplicate_merge_exception(self, project): - result = run_dbt(["run", "-s", "model"]) + result = run_dbt(["run", "-s", "model"], expect_pass=False) assert len(result) == 1 assert "Duplicate field key '[redacted]'" in result[0].message