From ee14a0cc317d40031e4f1ad3bf07da8fa119aaf3 Mon Sep 17 00:00:00 2001 From: Quigley Malcolm Date: Tue, 26 Sep 2023 18:28:25 -0700 Subject: [PATCH] Update `MetricInputMeasure` parsing test to check null value coalescing options --- tests/parsing/test_metric_parsing.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/parsing/test_metric_parsing.py b/tests/parsing/test_metric_parsing.py index 71aec839..51362bfa 100644 --- a/tests/parsing/test_metric_parsing.py +++ b/tests/parsing/test_metric_parsing.py @@ -54,6 +54,8 @@ def test_legacy_metric_input_measure_object_parsing() -> None: measure: name: legacy_measure_from_object filter: "{{ dimension('some_bool') }}" + join_to_timespine: true + fill_nulls_with: 1 """ ) file = YamlConfigFile(filepath="inline_for_test", contents=yaml_contents) @@ -65,6 +67,8 @@ def test_legacy_metric_input_measure_object_parsing() -> None: assert metric.type_params.measure == PydanticMetricInputMeasure( name="legacy_measure_from_object", filter=PydanticWhereFilter(where_sql_template="""{{ dimension('some_bool') }}"""), + join_to_timespine=True, + fill_nulls_with=1, )