-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Remove dbt-postgres
dependency
#811
Comments
Need to communicate that this would break any redshift user who is depending on overwriting a postgres macro. |
This change would be much appreciated. dbt-postgres 1.8.0 is creating issues for those running Linux due to a change in Psycopg2 dependencies, see dbt-labs/dbt-postgres#96 dbt-redshift does not need Psycopg2 anymore, so removing this dependency is a much needed simplfication. 🙏 |
We've identified a blocker for this work:
|
Describe the feature
dbt-redshift
depends ondbt-postgres
for 8 macros. These are all "pass-through" macros, e.g.:{% macro redshift__create_schema(relation) -%} {{ postgres__create_schema(relation) }} {% endmacro %}
We can eliminate the dependency on
dbt-postgres
through a combination of vendoring thedbt-postgres
macros intodbt-redshift
and simply relying on the default indbt-adapters
.Tasks
dbt-postgres
macros (currently 7 instances inadapters.sql
and 1 insnapshot_merge.sql
)adapters.redshift.__init__.py
dbt-postgres
intests
(currently 1 intest_macros.py
, 1 intest_query_comment.py
, and 1 comment inunit/utils.py
)setup.py
anddev-requirements.txt
The text was updated successfully, but these errors were encountered: