Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should all tests be changed to data_tests? #505

Closed
BradCr opened this issue Oct 13, 2024 · 0 comments · Fixed by #514
Closed

Should all tests be changed to data_tests? #505

BradCr opened this issue Oct 13, 2024 · 0 comments · Fixed by #514
Assignees
Labels
enhancement New feature or request triage
Milestone

Comments

@BradCr
Copy link
Contributor

BradCr commented Oct 13, 2024

Describe the feature

While building a model from this project, I see a warning message about tests being deprecated soon.

$ dbt compile --select fct_model_directories
19:16:47  Running with dbt=1.8.7
19:16:48  [WARNING]: Deprecated functionality
The `tests` config has been renamed to `data_tests`. Please see https://docs.getdbt.com/docs/build/data-tests#new-data_tests-syntax for more
information.

The tests aren't actually going to be deprecated, but using tests is no longer the best practice and we should use data_tests instead.

My question is, should we change all the tests in this project to be data_tests? Even if the warning message disappears in a future version of dbt-core, I think we want this package to follow the best practices.

Describe alternatives you've considered

Haven't considered anything else.

Additional context

None.

Who will this benefit?

Users running the dbt-project-evaluator won't see these warning messages, and anyone who examines the code for this package will see it conforms to best practices.

Are you interested in contributing this feature?

Yes, I can make this change if it is needed.

@BradCr BradCr added enhancement New feature or request triage labels Oct 13, 2024
@BradCr BradCr changed the title Should we change all tests to be data_tests? Should all tests be changed to data_tests? Oct 16, 2024
@dave-connors-3 dave-connors-3 added this to the v1.0.0 milestone Oct 24, 2024
@b-per b-per closed this as completed in #514 Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants