Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Under the hood] Standardize on "Adapter Integration Tests" GitHub workflow #181

Closed
3 tasks done
dbeatty10 opened this issue Dec 11, 2024 · 1 comment · May be fixed by #182
Closed
3 tasks done

[Under the hood] Standardize on "Adapter Integration Tests" GitHub workflow #181

dbeatty10 opened this issue Dec 11, 2024 · 1 comment · May be fixed by #182
Labels
enhancement New feature or request tech_debt

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Dec 11, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-postgres functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Current

The adapter integration for most adapters maintained by dbt Labs can be found here:

https://github.com/dbt-labs/dbt-postgres/actions/workflows/integration.yml

But the ones for dbt-postgres are here instead:

https://github.com/dbt-labs/dbt-postgres/actions/workflows/integration-tests.yml

The difference is a file name of integration-tests.yml instead of integration.yml.

Proposed

The proposed feature is two-fold:

  1. Rename the workflow file from integration-tests.yml to integration.yml
  2. Standardize the workflow definitions so that dbt-postgres and dbt-redshift so they only differ where they need to (e.g., environment variables, etc.).

Describe alternatives you've considered

No response

Who will this benefit?

People testing a PR in dbt-adapters against each of the adapter repos maintained by dbt Labs, like here: dbt-labs/dbt-adapters#372 (comment)

Are you interested in contributing this feature?

No response

Anything else?

No response

@dbeatty10 dbeatty10 added enhancement New feature or request triage labels Dec 11, 2024
@dbeatty10 dbeatty10 changed the title [Feature] Standardize on Adapter Integration Tests GitHub workflow [Feature] Standardize on "Adapter Integration Tests" GitHub workflow Dec 11, 2024
@dbeatty10 dbeatty10 changed the title [Feature] Standardize on "Adapter Integration Tests" GitHub workflow [Under the hood] Standardize on "Adapter Integration Tests" GitHub workflow Dec 11, 2024
@mikealfare
Copy link
Contributor

The standardization will effectively happen when we merge all of this into the monorepo. The workflow to run integration tests will probably be _integration-tests.yml, though this isn't expected to be run directly. It will get called by other workflows, such as pull-request-checks.yml and publish.yml. If there is another use case that we need to support, we can add another implementation workflow specific to that use case in the dbt-adapters repo. Let me know if the standardization aspect was the main goal, or if there is something beyond that which we would miss. In the meantime, I'd rather close this as a duplicate of a subset of the monorepo work.

@mikealfare mikealfare closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tech_debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants