You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dbeatty10
changed the title
[Feature] Standardize on Adapter Integration Tests GitHub workflow
[Feature] Standardize on "Adapter Integration Tests" GitHub workflow
Dec 11, 2024
dbeatty10
changed the title
[Feature] Standardize on "Adapter Integration Tests" GitHub workflow
[Under the hood] Standardize on "Adapter Integration Tests" GitHub workflow
Dec 11, 2024
The standardization will effectively happen when we merge all of this into the monorepo. The workflow to run integration tests will probably be _integration-tests.yml, though this isn't expected to be run directly. It will get called by other workflows, such as pull-request-checks.yml and publish.yml. If there is another use case that we need to support, we can add another implementation workflow specific to that use case in the dbt-adapters repo. Let me know if the standardization aspect was the main goal, or if there is something beyond that which we would miss. In the meantime, I'd rather close this as a duplicate of a subset of the monorepo work.
Is this your first time submitting a feature request?
Describe the feature
Current
The adapter integration for most adapters maintained by dbt Labs can be found here:
https://github.com/dbt-labs/dbt-postgres/actions/workflows/integration.yml
But the ones for
dbt-postgres
are here instead:https://github.com/dbt-labs/dbt-postgres/actions/workflows/integration-tests.yml
The difference is a file name of
integration-tests.yml
instead ofintegration.yml
.Proposed
The proposed feature is two-fold:
integration-tests.yml
tointegration.yml
dbt-postgres
anddbt-redshift
so they only differ where they need to (e.g., environment variables, etc.).Describe alternatives you've considered
No response
Who will this benefit?
People testing a PR in
dbt-adapters
against each of the adapter repos maintained by dbt Labs, like here: dbt-labs/dbt-adapters#372 (comment)Are you interested in contributing this feature?
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: