Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD Improvements] Update and simplify CD workflows #139

Closed
8 tasks
Tracked by #74
mikealfare opened this issue Aug 7, 2024 · 1 comment
Closed
8 tasks
Tracked by #74

[CI/CD Improvements] Update and simplify CD workflows #139

mikealfare opened this issue Aug 7, 2024 · 1 comment

Comments

@mikealfare
Copy link
Contributor

mikealfare commented Aug 7, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-postgres functionality, rather than a Big Idea better suited to a discussion

Describe the feature

As a maintainer, I want to simplify the CD jobs, so that deployment is more reliable and stable.

Acceptance Criteria

Preview Give feedback

Suggestions

  • Create two workflows:
    • release-cloud.yml
      • Exists as release-internal
      • Run on schedule: 22:00 UTC
      • Run on workflow_dispatch
      • Test against private PyPI
      • Slack notification on failure
    • release-open-source.yml
      • Exists as release
      • Run on workflow_dispatch
      • Test against public PyPI
      • Slack notification on failure

Style standards:

  • Job ids, step ids, and variables are in kebab case
  • Job names, step names, and description fields follow dbt docs standards (capitalize first word only)
  • Extra descriptors should be avoided unless required for disambiguation, e.g.
    • version-number -> version
    • archive-name -> archive
  • Workflow files use a four space tab
  • Scripts (inline or separate files) use environment variables in env instead of inline substitution like ${{ inputs.value }}
@mikealfare
Copy link
Contributor Author

This will happen as part of the monorepo work, hence this is duplicative.

@mikealfare mikealfare closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant