Synapse support is broken

[onefloid]

Describe the bug

I use dbt-synapse and I can't stage the external sources. I always get

  Encountered an error while running operation: Compilation Error in macro stage_external_sources (macros/common/stage_external_sources.sql)
   Staging external sources is not implemented for the default adapter

It seems that the adapter.dispatch() for synapse-dbt does not recognize the sqlserver__ macros.

Potential solution

I have done a little research. The bug was introduced with the following refactoring PR: #110

After reverting the commit 705a9e4 and skip the create schema for external tables if not exists from 34c1cc4, it works for my setup again.

System information

packages.yml file:

packages:
  - package: dbt-labs/dbt_external_tables
    version: 0.9.0

Database: Synapse

dbt version:

Core:
  - installed: 1.8.2
  - latest:    1.8.2 - Up to date!

Plugins:
  - fabric:  1.8.6 - Up to date!
  - synapse: 1.8.0 - Up to date!

OS: Ubuntu 22.04.1 LTS
python: Python 3.10.12

[dataders]

@onefloid recently, dbt-synapse was changed to inherit from dbt-fabric instead of dbt-sqlserver. To remedy this, the macros in the macros/plugins/sqlserver/ directory need to be renamed to have either fabric__ or synapse__ as a prefix instead of sqlserver__.

you can do this today by adding these renamed macros to your own project's macros/ directory.

👁️ @prdpsvs

[github-actions]

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

[timomarks]

@dataders
Thanks, with your workaround the error vanishes but now I get

 Encountered an error while running operation: Compilation Error
  macro 'dbt_macro__default__dropif' takes not more than 0 argument(s)

  > in macro dropif (macros\common\helpers\dropif.sql)
  > called by macro synapse__get_external_build_plan (macros\get_external_build_plan.sql)
  > called by macro get_external_build_plan (macros\common\get_external_build_plan.sql)
  > called by macro stage_external_sources (macros\stage_external_sources.sql)
  > called by <Unknown>

Edit: After a clean install of all dependencies it now works as intended