Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3182] [Feature] Bump version of dbt-semantic-interfaces to include jsonschema>=4.19 for 1.6 compatibility with Airflow>=2.6.3 #8767

Closed
3 tasks done
codecae opened this issue Oct 4, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@codecae
Copy link

codecae commented Oct 4, 2023

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Airflow>=2.6.3 is not compatible with dbt-core~=1.6 due to a conflict in the version of jsonschema in dbt-semantic-interfaces 0.2.0.

The core issue is that jsonschema has deprecated the jsonschema.RefResolver in favor of referencing.registry after 4.18. Unfortunately, the to-be-removed object intended to make it reverse compatible isn't entirely bug-free. Consequently, this created a snag in the timeline for dbt-semantic-interfaces, on which dbt-core is dependent.

The issue in dbt-semantic-interfaces has seemingly been addressed in this pull request. While I realize that requires a dependent release on the other repo I feel quite strongly that folks, such as myself that use dbt-core in the same venv as airflow, would be quite elated to be able to upgrade Airflow to more recent versions after this dependency update is resolved.

Describe alternatives you've considered

There are no other viable alternatives at this time other than staying at dbt-core 1.5.

Who will this benefit?

This will benefit all Airflow users that wish to upgrade to use dbt~=1.6 with Airflow>=2.6.3

Are you interested in contributing this feature?

I have contributed to this feature by resolving the issue in the pull request referenced above.

Anything else?

No response

@codecae codecae added enhancement New feature or request triage labels Oct 4, 2023
@github-actions github-actions bot changed the title [Feature] Bump version of dbt-semantic interfaces to include jsonschema>=4.19+ for 1.6 compatibility with Airflow>=2.6.3 [CT-3182] [Feature] Bump version of dbt-semantic interfaces to include jsonschema>=4.19+ for 1.6 compatibility with Airflow>=2.6.3 Oct 4, 2023
@codecae codecae changed the title [CT-3182] [Feature] Bump version of dbt-semantic interfaces to include jsonschema>=4.19+ for 1.6 compatibility with Airflow>=2.6.3 [CT-3182] [Feature] Bump version of dbt-semantic interfaces to include jsonschema>=4.19 for 1.6 compatibility with Airflow>=2.6.3 Oct 4, 2023
@codecae codecae changed the title [CT-3182] [Feature] Bump version of dbt-semantic interfaces to include jsonschema>=4.19 for 1.6 compatibility with Airflow>=2.6.3 [CT-3182] [Feature] Bump version of dbt-semantic-interfaces to include jsonschema>=4.19 for 1.6 compatibility with Airflow>=2.6.3 Oct 4, 2023
@QMalcolm
Copy link
Contributor

QMalcolm commented Oct 5, 2023

@codecae there is no work in dbt-core to be done to get 1.6.x to support this. We're backporting (dbt-labs/dbt-semantic-interfaces#165) your work in dbt-semantic-interfaces (dbt-labs/dbt-semantic-interfaces#160) to the 0.2.latest branch in dbt-semantic-interfaces. Once we merge that, we're going to do a release of dbt-semantic-interfaces 0.2.2. In dbt-core 1.6.latest the dependency specification for DSI is dbt-semantic-interfaces~=0.2.0 as seen here, which means the changes will automatically get picked up.

@QMalcolm
Copy link
Contributor

QMalcolm commented Oct 5, 2023

Closing because there is no work to be done in core for this. I'll add another comment here though once DSI 0.2.2 is released.

@QMalcolm QMalcolm closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2023
@codecae
Copy link
Author

codecae commented Oct 5, 2023

@QMalcolm my apologies -- I seemed to recall that the version pin in /core was more restrictive, but it seems accomodating to a 0.2.2 patch release.

Disregard! :)

@dbeatty10 dbeatty10 removed the triage label Oct 5, 2023
@QMalcolm
Copy link
Contributor

QMalcolm commented Oct 5, 2023

@codecae we've released 0.2.2 of DSI, if you fresh install your dbt environment it should be picked up 🙂

@codecae
Copy link
Author

codecae commented Oct 7, 2023

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants