Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2756] [Bug] relation_name is always None on SeedNode #7976

Open
aranke opened this issue Jun 28, 2023 · 4 comments
Open

[CT-2756] [Bug] relation_name is always None on SeedNode #7976

aranke opened this issue Jun 28, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@aranke
Copy link
Member

aranke commented Jun 28, 2023

Found during 🎩 for #7881

A/C:

  1. relation_name is correct on SeedNode
@aranke aranke added bug Something isn't working triage labels Jun 28, 2023
@github-actions github-actions bot changed the title [Bug] relation_name is always None on SeedNode [CT-2756] [Bug] relation_name is always None on SeedNode Jun 28, 2023
@jtcohen6
Copy link
Contributor

@aranke Is relation_name always none? Or at a specific point in time where we expect it to be populated?

This is running off the main branch (v1.6.0-b8):

$ dbt -q ls --resource-type seed --output json --output-keys name relation_name
{"name": "my_seed", "relation_name": "\"jerco\".\"dbt_jcohen\".\"my_seed\""}

Looking at e761aa0: Is it possible that this issue is about compiled_code, rather than relation_name? It's true that a seed's raw_code and compiled_code are both always None!

Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Jan 16, 2024
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2024
@dbeatty10 dbeatty10 removed the stale Issues that have gone stale label Feb 14, 2024
@dbeatty10 dbeatty10 reopened this Feb 14, 2024
@dbeatty10
Copy link
Contributor

Re-opened since we have some source code pointing to this issue:

if getattr(self.model, "defer_relation", None) and self.config.args.which == "clone":
# TODO https://github.com/dbt-labs/dbt-core/issues/7976
return f"select * from {self.model.defer_relation.relation_name or str(self.defer_relation)}" # type: ignore[union-attr]

If we want to re-close this for some reason, then we should consider removing that comment in the source code as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants