Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix circular import #11137

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix circular import #11137

wants to merge 3 commits into from

Conversation

dradetsky
Copy link

@dradetsky dradetsky commented Dec 11, 2024 •
edited by dbeatty10
Loading

resolves #11142

Problem

There was a circular import which required duplicating a method in core/dbt/config/profile.py. This was both ugly and an impediment to improving that method if required (as in #11108).

Solution

Fix the circular import and remove the duplication

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@dradetsky dradetsky requested a review from a team as a code owner December 11, 2024 21:25
@cla-bot cla-bot bot added the cla:yes label Dec 11, 2024
@github-actions github-actions bot added the community This PR is from a community member label Dec 11, 2024
@dbeatty10 dbeatty10 mentioned this pull request Dec 12, 2024
Open
3 tasks
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (6621015) to head (f89980b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11137      +/-   ##
==========================================
- Coverage   88.91%   88.86%   -0.06%     
==========================================
  Files         183      186       +3     
  Lines       23937    23971      +34     
==========================================
+ Hits        21284    21302      +18     
- Misses       2653     2669      +16
Flag Coverage Δ
integration 86.17% <100.00%> (-0.12%) ⬇️
unit 61.97% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 61.97% <100.00%> (+0.02%) ⬆️
Integration Tests 86.17% <100.00%> (-0.12%) ⬇️

@dradetsky
Copy link
Author

wow, I didn't know I fixed an issue! good job me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeatty10 dbeatty10 dbeatty10 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla:yes community This PR is from a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tech debt] Remove duplicated definition of default_profiles_dir (without adding circular dependency)
2 participants
@dradetsky @dbeatty10