Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Extend partial parsing behavior for env vars to project vars also #10578

Open
3 tasks done
dbeatty10 opened this issue Aug 16, 2024 · 2 comments
Open
3 tasks done
Labels
enhancement New feature or request

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Aug 16, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Avoid full parses and use partial parsing when project vars have not changed.

The implementation would more granularly track where those inputs are being used — that is, extending what we've done for env vars to project vars. I believe the relevant partial parsing code related to environment variables is here.

Describe alternatives you've considered

No response

Who will this benefit?

This will allow dbt to complete the parsing phase faster by using partial parsing to only parse the changed files (or files related to those changes).

Are you interested in contributing this feature?

No response

Anything else?

From dbt-labs/docs.getdbt.com#1066 (comment) and #9844 (comment)

@donjin-master
Copy link
Contributor

Hey @dbeatty10, From past few days i am trying to implement the tracking for --vars. Please correct me if i am thinking in wrong direction.

  1. We want to track all the --vars which we passed in the cli?
  2. If we were considering cli, then to track the changes we would be saving the cli_vars in manifest and we can track all the changes like we did for env_var.
  3. This point is a question, what about the ordering of the cli_vars. Do we require ordering of the cli_vars, it could create a different filehash from prev one if order changed?

Do add up any points which i should be taken care of in implementing this one.

@dbeatty10
Copy link
Contributor Author

@donjin-master this one is complicated enough that we'll probably wait until we can implement this ourselves rather than accept a community contribution.

Were you hoping to create a solution for this one specifically because it is relevant to one of your workflows? Or are you just generally looking to contribute to something to dbt-core? If the latter, here's where you can find issues that we've labeled for community contributors:

@dbeatty10 dbeatty10 changed the title [Feature] Extend partial parsing behavior for env vars to --vars also [Feature] Extend partial parsing behavior for env vars to project vars also Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants