Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Record/Replay #90

Merged
merged 11 commits into from
Feb 28, 2024
Merged

Implement Record/Replay #90

merged 11 commits into from
Feb 28, 2024

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Feb 26, 2024

resolves dbt-labs/dbt-core#9689

Description

Implements record/replay mechanism. See issue for the many details.

Checklist

@peterallenwebb peterallenwebb requested a review from a team as a code owner February 26, 2024 18:54
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

dbt_common/record.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.71739% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 55.77%. Comparing base (87d9c54) to head (97a69f9).

Files Patch % Lines
dbt_common/record.py 73.77% 32 Missing ⚠️
dbt_common/clients/system.py 85.24% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   54.04%   55.77%   +1.72%     
==========================================
  Files          49       50       +1     
  Lines        2866     3050     +184     
==========================================
+ Hits         1549     1701     +152     
- Misses       1317     1349      +32     
Flag Coverage Δ
unit 55.77% <77.71%> (+1.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterallenwebb peterallenwebb added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit ae8ffe0 Feb 28, 2024
13 checks passed
@peterallenwebb peterallenwebb deleted the paw/record branch February 28, 2024 21:28
@farmanp
Copy link

farmanp commented Jun 30, 2024

Implements record/replay mechanism. See issue for the many details.

I'm curious to know what the issue says but when I go to it, the description is just a JIRA ticket that isn't accessible to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Record/Replay Mechanism
4 participants