From 6a2dd30f43d384af769a3cae7f46bf3fffcce7db Mon Sep 17 00:00:00 2001 From: Emily Rockman Date: Wed, 5 Jun 2024 09:06:14 -0500 Subject: [PATCH] comments --- dbt_common/record.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dbt_common/record.py b/dbt_common/record.py index d33632f8..b053cddc 100644 --- a/dbt_common/record.py +++ b/dbt_common/record.py @@ -63,6 +63,7 @@ def __init__(self, current_recording_path: str, previous_recording_path: str) -> def diff_query_records(self, current: List, previous: List) -> Dict[str, Any]: # some of the table results are returned as a stringified list of dicts that don't diff because order isn't consistent + # convert it into a list of dicts so it can be diffed, ignoring order for i in range(len(current)): if current[i].get("result").get("table") is not None: current[i] = json.loads(current[i]["result"]["table"]) @@ -89,7 +90,7 @@ def diff_default(self, current: List, previous: List) -> Dict[str, Any]: return DeepDiff(current, previous, ignore_order=True, verbose_level=2) def calculate_diff(self) -> Dict[str, Any]: - # TODO: should i convert the files to Records and diff the records? + # TODO: should i convert the files to Records and diff the records? blocked on this for now by MNTL-308 with open(self.current_recording_path) as current_recording: current_dct = json.load(current_recording)