Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support preserving capitalisation for models and columns #188

Closed
Thrasi opened this issue Nov 10, 2024 · 1 comment
Closed

Support preserving capitalisation for models and columns #188

Thrasi opened this issue Nov 10, 2024 · 1 comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@Thrasi
Copy link
Contributor

Thrasi commented Nov 10, 2024

Describe the feature

generate_model_yaml.sql lower cases every model and column name.
add support for preserving capitalisation.

Describe alternatives you've considered

Add two optional parameter to the macro, one for model names and one for column names to control the behaviour.

Who will this benefit?

Anyone working with a database with a naming standard where capitalisation is important. This is related to the issue related to generate_source_yaml.

Are you interested in contributing this feature?

Yes, I have what I believe is a working solution to the issue.

@Thrasi Thrasi added enhancement New feature or request triage labels Nov 10, 2024
@dbeatty10
Copy link
Contributor

Thanks for reaching out @Thrasi !

This looks like the same/similar thing as requested in #175, so I'm going to close this one as a duplicate.

Would welcome any additional thoughts you have over there. Since you closed your draft PR, would also be interested to learn if you came up with a workaround.

@dbeatty10 dbeatty10 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2024
@dbeatty10 dbeatty10 added duplicate This issue or pull request already exists and removed triage labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants