Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Remove keyfile from BigQueryCredentials._connection_keys #1146

Closed
2 tasks done
McKnight-42 opened this issue Mar 22, 2024 · 0 comments · Fixed by #1147
Closed
2 tasks done

[Bug] Remove keyfile from BigQueryCredentials._connection_keys #1146

McKnight-42 opened this issue Mar 22, 2024 · 0 comments · Fixed by #1147
Assignees
Labels
bug Something isn't working

Comments

@McKnight-42
Copy link
Contributor

Is this a new bug in dbt-bigquery?

  • I believe this is a new bug in dbt-bigquery
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

follow-up to dbt-labs/dbt-snowflake#906 + dbt-labs/dbt-snowflake#756

keyfile is included in BigQueryCredentials._connetion_keys, and therefore the Jinja {{ target }} dictionary. While this value doesn't explicitly contain sensitive information itself, I'd put it in the category of password-like fields rather than the category of fields that a user needs to access at runtime.

Expected Behavior

keyfile is not included in _connection_keys

Steps To Reproduce

n/a

Relevant log output

n/a

Environment

- OS:
- Python:
- dbt-core:
- dbt-bigquery:

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants