Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop adding aliases to render_limited output #749

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

Dewwi
Copy link
Contributor

@Dewwi Dewwi commented Oct 23, 2024

Description

see: dbt-labs/dbt-adapters#124

Here are some reference implementations:

dbt-labs/dbt-bigquery@49d6c1e
dbt-labs/dbt-snowflake@0153bd0
dbt-labs/dbt-bigquery@49d6c1e

Models used to test - Optional

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

@Dewwi Dewwi requested a review from a team as a code owner October 23, 2024 14:50
@Dewwi Dewwi force-pushed the require-alias-false branch from 1ae6df7 to a9994fc Compare October 24, 2024 09:53
@nicor88
Copy link
Contributor

nicor88 commented Nov 26, 2024

@colin-rogers-dbt could you review please?

@Dewwi
Copy link
Contributor Author

Dewwi commented Dec 2, 2024

Hi team - do we have any visibility on the timelines for when we’ll be able to merge this? It seems straightforward enough. Let me know if there's anything else I can do to fast-track this?

@colin-rogers-dbt colin-rogers-dbt merged commit 8f6b1f0 into dbt-labs:main Dec 2, 2024
11 checks passed
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Dec 2, 2024
4 tasks
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Dec 9, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants