From 8b3387fffdc6fbae457472cf203a62c5ffcdc7cc Mon Sep 17 00:00:00 2001 From: Mike Alfare <13974384+mikealfare@users.noreply.github.com> Date: Mon, 28 Oct 2024 17:15:43 -0400 Subject: [PATCH 1/2] Run on `pull_request_target` to pick up environment variables and secrets on forks (#750) --- .github/workflows/pull-request-checks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request-checks.yml b/.github/workflows/pull-request-checks.yml index 3ca27145..f977dfc1 100644 --- a/.github/workflows/pull-request-checks.yml +++ b/.github/workflows/pull-request-checks.yml @@ -1,7 +1,7 @@ name: "Pull request checks" on: - pull_request: + pull_request_target: types: [opened, reopened, synchronize] # only run this once per PR at a time From 3e6d0432b06de0ee90b21c9823e7815c863a3d6a Mon Sep 17 00:00:00 2001 From: nicor88 <6278547+nicor88@users.noreply.github.com> Date: Mon, 28 Oct 2024 22:28:51 +0100 Subject: [PATCH 2/2] fix: increase iceberg retries in integration tests (#746) Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com> --- dbt-athena/tests/functional/adapter/test_retries_iceberg.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dbt-athena/tests/functional/adapter/test_retries_iceberg.py b/dbt-athena/tests/functional/adapter/test_retries_iceberg.py index 9bfb7821..f4711d9d 100644 --- a/dbt-athena/tests/functional/adapter/test_retries_iceberg.py +++ b/dbt-athena/tests/functional/adapter/test_retries_iceberg.py @@ -101,8 +101,8 @@ class TestIcebergRetriesEnabled: @pytest.fixture(scope="class") def dbt_profile_target(self): profile = copy.deepcopy(base_dbt_profile) - # we set the iceberg retries to the same number of parallelism to make sure that the retries are working - profile["num_iceberg_retries"] = PARALLELISM * 2 + # we set iceberg retries to a high number to ensure that the test will pass + profile["num_iceberg_retries"] = PARALLELISM * 5 return profile @pytest.fixture(scope="class")