[Bug] Is the '`' symbol in the log the expected result?

[peter-huang-xfers]

Is this a new bug in dbt-core?

• I believe this is a new bug in dbt-core
• I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

04:26:08  1 of 1 START sql table model sta_datamart_dev.pma_segmentation_v3 .............. [RUN]
04:26:12  Detected columns with numeric type and unspecified precision/scale, this can lead to unintended rounding: ['gmv_d90_transfer', 'revenue_d90_transfer']`

Is the '`' symbol in the end of the log the expected result?

Expected Behavior

04:26:08  1 of 1 START sql table model sta_datamart_dev.pma_segmentation_v3 .............. [RUN]
04:26:12  Detected columns with numeric type and unspecified precision/scale, this can lead to unintended rounding: ['gmv_d90_transfer', 'revenue_d90_transfer']

Steps To Reproduce

I'm using BigQuery, and the issue can be reproduced by creating a table without assigning precision and scale to the numeric data type column.

Relevant log output

No response

Environment

- OS:
- Python:
- dbt-core: 1.7.13
- dbt-bigquery: 1.7.7

Which database adapter are you using with dbt?

bigquery

Additional Context

No response

[dbeatty10]

Thanks for noticing this and reaching out @peter-huang-xfers !

This looks like it was unintentional or vestigial to me. But it also seems like it isn't causing any harm -- just a rogue extra character -- does that sound right?

Regardless, it seems like the fix would be easy, just remove the ~ "`" part from here:

dbt-adapters/dbt/include/global_project/macros/adapters/columns.sql

Line 61 in df393ae

{{ exceptions.warn("Detected columns with numeric type and unspecified precision/scale, this can lead to unintended rounding: " ~ col_naked_numeric ~ "`") }}

I would expect these two test cases to still pass after that change:

• https://github.com/dbt-labs/dbt-core/blob/29b83598e3530e99a441e4b6de51f9f9dace781f/tests/functional/contracts/test_contract_precision.py#L44
• https://github.com/dbt-labs/dbt-core/blob/29b83598e3530e99a441e4b6de51f9f9dace781f/tests/functional/contracts/test_contract_precision.py#L61