You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched the existing issues, and I could not find an existing issue for this feature
I am requesting a straightforward extension of existing dbt-adapter functionality, rather than a Big Idea better suited to a discussion
Describe the feature
As we have decided not to remove dbt-core as an install requirement for adapters we need a check to prevent it from being re-introduced as a code dependency.
To do so we should add a pre-commit check that all implementing adapters can reference in dbt-adapters. This check would parse the imports and raise an error if dbt-core is imported. https://pre-commit.com/#new-hooks
Describe alternatives you've considered
Unit/Functional test - decided against this as this isn't really a code "test" but a check similar to what a linter like mypy would do.
Who will this benefit?
No response
Are you interested in contributing this feature?
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered:
Is this your first time submitting a feature request?
Describe the feature
As we have decided not to remove dbt-core as an install requirement for adapters we need a check to prevent it from being re-introduced as a code dependency.
To do so we should add a pre-commit check that all implementing adapters can reference in dbt-adapters. This check would parse the imports and raise an error if
dbt-core
is imported.https://pre-commit.com/#new-hooks
Describe alternatives you've considered
Unit/Functional test - decided against this as this isn't really a code "test" but a check similar to what a linter like mypy would do.
Who will this benefit?
No response
Are you interested in contributing this feature?
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: