Improve XML sanitization in advanced mode to fix broken entities. #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaiter
force-pushed
the
sanitization-improvements
branch
from
cd525bb to
a9be01c
Compare
Previously we'd only check if a candidate entity was properly terminated by a semicolon, which missed some broken XML we have in legacy projects. The check is now much more thorough and mimicks much of the process the parser itself does when parsing entities.
jbaiter
force-pushed
the
sanitization-improvements
branch
from
a9be01c to
784454e
Compare
schmika
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd only check if a candidate entity was properly terminated by a semicolon, which missed some broken XML we have in legacy projects. The check is now much more thorough and mimicks much of the process the parser itself does when parsing entities.