Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorting by [range] #79

Open
buseca opened this issue Nov 29, 2023 · 3 comments
Open

sorting by [range] #79

buseca opened this issue Nov 29, 2023 · 3 comments

Comments

@buseca
Copy link
Collaborator

buseca commented Nov 29, 2023

current sorting by range results in unexpected things, for example if I use a descending order, the 2-3 range comes before the 1-5.

I think we should consider this logic instead:

  • If the users select ASCENDING, it means they are interested in seeing lower ranges first. Hence we should take the low limit of the range and sort by it.
  • If the they select DESCENDING, they are interested in the higher ranges. Hence we should sort considering the high limit of the ranges.

Image

@buseca buseca added this to Relist Nov 29, 2023
@buseca buseca converted this from a draft issue Nov 29, 2023
@buseca
Copy link
Collaborator Author

buseca commented Nov 29, 2023

@dbertella what you think?

@dbertella
Copy link
Owner

Yeah I see it's a bit of a pain. I don't get your logic though. Are you saying that if I have 1-5 and I sort by ascending order we should use 1 or 5?
I think you should take 1 for ascending and 5 for descending. But yeah let me check the current logic and I can fix it

@buseca
Copy link
Collaborator Author

buseca commented Nov 30, 2023

Right, I mistaken the description.
Ascending --> low limit range
Descending --> upper limit range

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants