From 590830cbb57d29df714b450a63abe9c1187e2daf Mon Sep 17 00:00:00 2001 From: sergeyteleshev Date: Mon, 5 Feb 2024 13:47:23 +0100 Subject: [PATCH] CB-4605 fix: sql editor shows datasets panels correctly (#2347) * CB-4605 fix: sql editor shows datasets panels correctly * Revert "CB-4605 fix: sql editor shows datasets panels correctly" This reverts commit 5e2afc5296da6cca2d72da1c94b307b365141692. * CB-4605 fix: TE edit dataset works fine with new dividers * CB-4605 revert sqleditor displayed editors state * CB-4605 removed sqlEditor hack to open full size dataset * Revert "CB-4605 removed sqlEditor hack to open full size dataset" This reverts commit 7ad98e42b4c17e740e804cb0b7ac6e37f2c4b4a5. * CB-4605 sqlEditor works as it was for EE and TE --------- Co-authored-by: s.teleshev Co-authored-by: Evgenia Bezborodova <139753579+EvgeniaBzzz@users.noreply.github.com> --- webapp/packages/plugin-sql-editor/src/SqlEditor.tsx | 4 ++-- .../packages/plugin-sql-editor/src/SqlEditor/SqlEditor.tsx | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/webapp/packages/plugin-sql-editor/src/SqlEditor.tsx b/webapp/packages/plugin-sql-editor/src/SqlEditor.tsx index 83a0671135..4a9778d3de 100644 --- a/webapp/packages/plugin-sql-editor/src/SqlEditor.tsx +++ b/webapp/packages/plugin-sql-editor/src/SqlEditor.tsx @@ -41,11 +41,11 @@ export const SqlEditor = observer(function SqlEditor({ state }) { - + - + diff --git a/webapp/packages/plugin-sql-editor/src/SqlEditor/SqlEditor.tsx b/webapp/packages/plugin-sql-editor/src/SqlEditor/SqlEditor.tsx index 566fa1f50b..b7f7b9a034 100644 --- a/webapp/packages/plugin-sql-editor/src/SqlEditor/SqlEditor.tsx +++ b/webapp/packages/plugin-sql-editor/src/SqlEditor/SqlEditor.tsx @@ -79,10 +79,9 @@ export const SqlEditor = observer(function SqlEditor({ state, c useEffect(() => { if (isEditorEmpty) { - split.fixate('maximize', true); + split.state.setDisable(true); } else if (split.state.disable) { - split.fixate('resize', false); - split.state.setSize(-1); + split.state.setDisable(false); } }, [isEditorEmpty]);