Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset not working and stickem not stopping at the bottom of the container #40

Open
pixxies opened this issue Dec 4, 2014 · 13 comments

Comments

@pixxies
Copy link

pixxies commented Dec 4, 2014

Title says it all really. I'm using it here: http://69.195.124.217/~freedqi4/health/when-in-doubt-reach-out/

@davist11
Copy link
Owner

davist11 commented Dec 8, 2014

You may want to try waiting until images are loaded before triggering stickem, as it changes the height of the container.

@jacobraccuia
Copy link

I'm having this problem - and even with a fixed height that I manually set, it doesn't stop at the bottom until I resize.

@davist11
Copy link
Owner

davist11 commented Dec 3, 2015

Do you have a link?

@jacobraccuia
Copy link

http://dev.daily-beat.com/listen-zeds-deads-incredible-remix-jack-u-take-u-feat-kiesza-preview/

I’d like to edit the link out once you have it, though, please.

Also sometimes on resize, it disappears while scrolling up.

On December 3, 2015 at 10:58:40 AM, Trevor Davis ([email protected]) wrote:

Do you have a link?


Reply to this email directly or view it on GitHub.

@jacobraccuia
Copy link

Turns out the flickering is actually caused from calling the sticky on page resize.  I removed that part of the code so it no longer flickers - but the original issue still stands.

Calling .resize(); after calling the stickem method doesn’t fix the problem.  Once I resize the page manually, the plugin recognizes the bottom of the container.

On December 3, 2015 at 10:58:40 AM, Trevor Davis ([email protected]) wrote:

Do you have a link?


Reply to this email directly or view it on GitHub.

@davist11
Copy link
Owner

davist11 commented Dec 4, 2015

That link goes to a 404

@jacobraccuia
Copy link

Sorry, it should be good now. Wordpress and silly permalinks that needed to be flushed.

@jacobraccuia
Copy link

@davist11 Hi! have you had a chance to look in / if the link is working for you now? No rush, just checking in.

@davist11
Copy link
Owner

There is a lot going on there. Any way you could simplify the example or pull it out into a CodePen?

@jacobraccuia
Copy link

I simplified the page itself here:
http://dev.daily-beat.com/zeds-dead-gobble-webster-hall-thanksgiving-eve-11-26-14/

but I’m not able to recreate the issue in codepen.  I have used the plugin on other pages of this website fine ( aka the homepage ) which makes me wonder.

i’m not sure how else you’d like me to simplify.  before calling the plugin, I am waiting till all images are loaded and resizing the left column to be the proper height.

On December 11, 2015 at 2:17:37 PM, Trevor Davis ([email protected]) wrote:

There is a lot going on there. Any way you could simplify the example or pull it out into a CodePen?


Reply to this email directly or view it on GitHub.

@davist11
Copy link
Owner

I'm having a hard time trying to figure out what's going on here. What's the reason you are adding an inline height of 1500px to <div class="col-fixed col-fixed-left pull-left">?

@jacobraccuia
Copy link

edit: I'm actually calculating the height of the center container and applying it to the left column. The height of the middle container is constantly changing, and therefore I'm setting a fixed height for the column to ensure that when the sticky sticks to the bottom, it is actually at the bottom of the container.

The height is calculated after all images / iframes have loaded, and it's updated when the page is resized.

I think it was just for troubleshooting at one point. I thought I had removed it. (which I will do ASAP).

if you're willing to go to meeting screen share I would be more than happy to. (and buy you a coffee/beer or a few for your troubles)

@jacobraccuia
Copy link

@davist11 sorry to bring this issue back up. I still haven't fixed it, but I was able to figure out something else.

http://dev.daily-beat.com/listen-zeds-deads-incredible-remix-jack-u-take-u-feat-kiesza-preview/

If I open firebug so it makes my window smaller, and I scroll 100% past the sticky bar, it works as intended. If i can't scroll completely past it, it will flash and disappear as I scroll up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants