Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container variable height #20

Open
got3nks opened this issue Mar 11, 2013 · 6 comments
Open

Container variable height #20

got3nks opened this issue Mar 11, 2013 · 6 comments

Comments

@got3nks
Copy link

got3nks commented Mar 11, 2013

In case the 'container' height can vary, there is a little fix required in handleScroll function.

            for(var i = 0, len = _self.items.length; i < len; i++) {
                var item = _self.items[i];

                if(item.$container.height()!=item.containerInnerHeight) {
                    item.scrollFinish = item.containerStart - _self.config.start + (item.$container.height() - item.elemHeight);
                }

This is useful if you change the page content using AJAX for example.

@rutger1140
Copy link

@got3nks Thanks a lot! Exactly the fix I was looking for. Perhaps you can put it in a PR so @davist11 can merge it?

@mylastore
Copy link

The code above

add or replace?

@rutger1140
Copy link

@mylastore
Copy link

Thanks it work 👍

@Dayjo
Copy link

Dayjo commented Nov 3, 2014

Pull request?

@mattgreenfield
Copy link

Pull Request - #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants