Some properties with default values not inserted

[IsmoKarkkainen]

Using insert_property_defaults results in some properties with defaults not being inserted. The attached txt file
defaults_issue.txt
is a ruby script that demonstrates the issue. Save and rename to defaults_issue.rb and run. (Attaching rb file was not allowed, hence renamed.)

1. When run as is, the check finds item4 is missing buggy.
2. When you change the order of buggy and bbbb in the schema, item4 is missing bbbb.
3. When you delete item5 from data, then item3 is missing cccc.
4. Have bbbb in schema as the first property and have item5 removed, then item3 is missing bbbb.
5. Have bbbb in schema as the first property and have item5 present, then item4 is missing bbbb.

There are probably other variations that produce something odd. I originally had meta_schema: 'https://spec.openapis.org/oas/3.1/dialect/base' but dropped that when simplifying the schema and data.

Ruby version 3.1.2, json_schemer 2.2.0.

[davishmcclurg]

Hi @IsmoKarkkainen! Thanks for opening this—it's a strange one. I think I found the problem and the fix: #180
Do you mind trying it out?

[IsmoKarkkainen]

Happy to try it out.

I changed the test script and the code that originally showed the problem with real schema and data to require_relative the json_schemer/lib/json_schemer in the new branch.

Test script still shows the issue but in the original code one case of missing property with default was fixed. Another one in there remains.

[davishmcclurg]

require_relative the json_schemer/lib/json_schemer in the new branch.

You might be getting the wrong code since require_relative doesn't set the rest of the require statements in lib/json_schemer.rb to load correctly. I usually take the easy way out and use bundler/inline for stuff like this. In your script, you can replace:

require 'json'
require 'json_schemer'

With:

require 'bundler/inline'
gemfile do
  source 'https://rubygems.org'
  gem 'json'
  gem 'json_schemer', path: '/path/to/json_schemer/repo/with/branch/checked/out'
end

Pulling directly from github also works, but it's slower to run:

gem 'json_schemer', git: 'https://github.com/davishmcclurg/json_schemer', branch: 'compare-instance-locations-by-identity'

[IsmoKarkkainen]

Ok, now the fields are present as the script does not complain and the real case has all omitted fields with defaults in place as well. Works. Thank you.