Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: sections rework #994

Closed
davidsneighbour opened this issue May 30, 2024 · 1 comment
Closed

feature: sections rework #994

davidsneighbour opened this issue May 30, 2024 · 1 comment
Assignees
Labels
type:enhancement New enhancements and features. type:refactor Code refactoring.

Comments

@davidsneighbour
Copy link
Owner

  • move any <section> to the outermost block within the page structure. the only thing that can be outside of <section> can be a single div with a container class.
    <main>
    <div class="container" id="first-block">
      <section>
      ...
      </section>
    </div>
    <section>
    ...
    </section>
    </main>
    (that container can be used for spacing and positioning)
  • any <section> must have a <header> with a headline tag with a proper counter
    <section>
      <header>
        <h2>Something</h2>
      </header>
      ...
    </section>
    use aria tags, visibility, and display classes to hide/show
@davidsneighbour davidsneighbour added type:enhancement New enhancements and features. type:refactor Code refactoring. state:confirmed This issue is confirmed. labels May 30, 2024
@davidsneighbour davidsneighbour self-assigned this May 30, 2024
@davidsneighbour davidsneighbour changed the title markup: sections rework markup: sections rework May 30, 2024
@davidsneighbour davidsneighbour changed the title markup: sections rework feature: sections rework Jul 30, 2024
@davidsneighbour
Copy link
Owner Author

seems to be done.

@github-actions github-actions bot removed prio:1 state:confirmed This issue is confirmed. labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New enhancements and features. type:refactor Code refactoring.
Projects
None yet
Development

No branches or pull requests

1 participant