Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: the mystery of the cut-off videos #933

Closed
davidsneighbour opened this issue May 12, 2024 · 3 comments
Closed

bug: the mystery of the cut-off videos #933

davidsneighbour opened this issue May 12, 2024 · 3 comments
Assignees
Labels
type:bug Bugfixes in codebase when something is not working.

Comments

@davidsneighbour
Copy link
Owner

The video shortcode has some issues communicating it's proportions (2:1) to the video itself so it ends up with 1/10th or so of cut content at the bottom. There was a point in time when this magically solved itself when the video was running, not so anymore.

@davidsneighbour davidsneighbour added type:bug Bugfixes in codebase when something is not working. state:confirmed This issue is confirmed. prio:1 labels May 12, 2024
@davidsneighbour davidsneighbour self-assigned this May 12, 2024
@davidsneighbour
Copy link
Owner Author

By the way, the 2:1 aspect ratio is the themes setup, not the shortcodes. Maybe it just need an aspectratio parameter.

@davidsneighbour
Copy link
Owner Author

There is a hard coded 16:9 aspect ratio in the youtube shortcode scss. Setting it to 16:8 might solve the issue, but break other implementations. Better is probably to make this a configuration parameter.

@davidsneighbour
Copy link
Owner Author

davidsneighbour commented May 24, 2024

Ah, was looking for this bug. Solved in 5ef95c7

@github-actions github-actions bot removed the state:confirmed This issue is confirmed. label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Bugfixes in codebase when something is not working.
Projects
None yet
Development

No branches or pull requests

1 participant