Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: "cards" don't have same height #928

Closed
davidsneighbour opened this issue May 11, 2024 · 0 comments
Closed

bug: "cards" don't have same height #928

davidsneighbour opened this issue May 11, 2024 · 0 comments
Assignees
Labels
type:bug Bugfixes in codebase when something is not working.

Comments

@davidsneighbour
Copy link
Owner

davidsneighbour commented May 11, 2024

this one will be a bit more invasive. cards (post preview in lists like the recent posts on the homepage, blog list pages, etc) do not have the same height when next to each other and having differing content.

Issue here is, that currently they are build via col classes that can run over multiple rows. We need to re-write that into flex rows that contain x posts (depending on the view) that we could force to stretch and then lay out properly. That will lead to issues with dynamic width column counts.

On the other side, we know the height of image --- headline (max 2 lines) --- content preview (max-3 lines) --- read more button. That might be solvable via min-height, but could look ugly on a 1 per row layout in sm/xs.

@davidsneighbour davidsneighbour added type:bug Bugfixes in codebase when something is not working. state:unconfirmed This issue needs to be reproduced. labels May 11, 2024
@davidsneighbour davidsneighbour self-assigned this May 11, 2024
@davidsneighbour davidsneighbour added state:confirmed This issue is confirmed. and removed state:unconfirmed This issue needs to be reproduced. labels May 11, 2024
@github-actions github-actions bot removed the state:confirmed This issue is confirmed. label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Bugfixes in codebase when something is not working.
Projects
None yet
Development

No branches or pull requests

1 participant