Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: default image uses small size #1078

Closed
davidsneighbour opened this issue Jul 14, 2024 · 0 comments
Closed

bug: default image uses small size #1078

davidsneighbour opened this issue Jul 14, 2024 · 0 comments
Assignees
Labels
type:bug Bugfixes in codebase when something is not working.

Comments

@davidsneighbour
Copy link
Owner

<picture>
<source srcset="" media="(max-width:520px)">
<source srcset="" media="(max-width:540px)">
<source srcset="" media="(max-width:720px)">
<source srcset="" media="(max-width:960px)">
<source srcset="" media="(min-width:960px)">
<img class="img-fluid" src="" alt="" width="684" height="457" loading="eager" fetchpriority="high"></picture>

Instead of 684x457, the largest size of the srcset (max-width, not min-width) should be used.

@davidsneighbour davidsneighbour added type:bug Bugfixes in codebase when something is not working. state:confirmed This issue is confirmed. labels Jul 14, 2024
@davidsneighbour davidsneighbour self-assigned this Jul 14, 2024
@github-actions github-actions bot removed the state:confirmed This issue is confirmed. label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Bugfixes in codebase when something is not working.
Projects
None yet
Development

No branches or pull requests

1 participant