Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request : allow variable player number on a game/env #6

Open
zorgluf opened this issue May 10, 2021 · 2 comments
Open

Feature request : allow variable player number on a game/env #6

zorgluf opened this issue May 10, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@zorgluf
Copy link
Contributor

zorgluf commented May 10, 2021

Hi !
It would be nice to be able to choose the number of players for a game, although I don't master the impact on the training loop (one model per number of players ?).
Is there any other limitation to implement this feature ?
Thanks for your answer and for all the work done.

@davidADSP
Copy link
Owner

Yes agreed - it's tricky as usually the model input shape is dependent on the number of players (e.g. 4 player sushi go requires the agent to keep track of 4 different hands, so a larger input shape than for the 3 player game). Therefore, it's currently not possible to utilise a model trained for a 3 player game for a 4 player game, and therefore they may as well be completely separate games in the folder.

I'm open to ideas as to how a n_player agnostic agent would work - totally agree it would be a cool feature!

@davidADSP davidADSP added the enhancement New feature or request label May 11, 2021
@aamonkeyA
Copy link

Wouldn't it be sufficient to always assume the max player count? Then you have the shape for 4-player sushi go and if you actually play with only 3 players, you zero out the extra players.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants