Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add a is_callsign_editable flag to Booking #836

Open
daveroverts opened this issue May 8, 2024 · 0 comments
Open

Feature: Add a is_callsign_editable flag to Booking #836

daveroverts opened this issue May 8, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@daveroverts
Copy link
Owner

Situation: Flights were imported containing a call_sign, but no aircraft_type. According to BookingsImport, when both call_sign and aircraft_type are filled in, these details are not allowed to be edited.

However, because aircraft_type was missing, is_editable is set to true. This meant 2 things:

  • Whenever somebody doesn't confirm / cancels their booking, both callsign and acType where set to null.
  • The callsign could be changed

The following needs to be done:

  • Add is_callsign_editable flag to Booking
  • If able without breaking too much: Rename is_editable to is_actype_editable
  • Ensure BookingsImport can handle the new flag
  • Change views + BookingController so it can handle the new flag as needed
@daveroverts daveroverts added the enhancement New feature or request label May 8, 2024
@daveroverts daveroverts self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant