S3 basic_external doesn't work

[pauldraper]

The signed S3 URL doesn't work for uploading.

Git LFS receives a 401 when uploading.

[devinnasar]

I believe this to be related to the configuration for signature version in the boto3 client here:

giftless/giftless/storage/amazon_s3.py

Line 29 in 5b3f720

self.s3_client = boto3.client("s3", endpoint_url=endpoint)

See this issue in botocore: boto/botocore#2109. If the fix indicated at the bottom were implemented it may correct the issue.

I'm receiving a similar message: "The request signature we calculated does not match the signature you provided. Check your key and signing method." when I try to run git push after following the tutorial for google cloud storage, but modified to run against s3.

[athornton]

Feel free to try it and make a PR. I'm at a conference this week but I can probably get to it next week (disclaimer: I don't work for Datopian, so my time to work on this is entirely at my management's discretion, so if stuff is blowing up, I won't, but at least right now it seems like I should be able to, since that looks like a very small change).

[devinnasar]

I'll give it a shot. I need to adjust my setup to try and use local giftless.

[rufuspollock]

@devinnasar did you get a PR in on this?

[rufuspollock]

@devinnasar @athornton any thoughts on this?

[athornton]

Yeah, I think I completely forgot this existed and utterly dropped the ball. Sorry.

I should take a look again.