Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Pulsar-JMS library producer.send() method #151

Closed
wants to merge 2 commits into from
Closed

Fix for Pulsar-JMS library producer.send() method #151

wants to merge 2 commits into from

Conversation

mukesh-ctds
Copy link
Collaborator

Fix for #LS-1292

@mukesh-ctds mukesh-ctds self-assigned this Aug 12, 2024
@dlg99 dlg99 requested a review from eolivelli August 13, 2024 15:24
dlg99
dlg99 requested changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@dlg99 dlg99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why message.setBlah(message.getBlah()) fixes anything.
It seems that the fix was to not overwrite the set value in message but it also threw away functionality that sets values from the producer.

See code comment/proposed change

pulsar-jms/src/main/java/com/datastax/oss/pulsar/jms/PulsarJMSProducer.java Outdated Show resolved Hide resolved
@mukesh-ctds mukesh-ctds requested a review from dlg99 August 14, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinath-ctds srinath-ctds Awaiting requested review from srinath-ctds

@eolivelli eolivelli Awaiting requested review from eolivelli

@dlg99 dlg99 Awaiting requested review from dlg99

Assignees

@mukesh-ctds mukesh-ctds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mukesh-ctds @dlg99