Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JMSPublishFilters: fix metadata cache and introduce new threadpool for acks #148

Merged
merged 2 commits into from
May 14, 2024
Merged

JMSPublishFilters: fix metadata cache and introduce new threadpool for acks #148

merged 2 commits into from
May 14, 2024

Conversation

eolivelli
Copy link
Collaborator

@eolivelli eolivelli commented May 14, 2024 •
edited
Loading

Modifications:

  • introduce a dedicated threadpool for handling acks in order to prevent a deadlock in which all the worker threads are trying to put into the acks queue, but no thread is able to drain
  • fix a regression in handling non-string properties

eolivelli
eolivelli commented May 14, 2024
View reviewed changes
...ms-filters/src/test/java/com/datastax/oss/pulsar/jms/selectors/MessageMetadataCacheTest.java
void testGetProperty() {
MessageMetadata metadata = new MessageMetadata();
metadata.addProperty().setKey("foo").setValue("bar");
metadata.addProperty().setKey("i_jsmtype").setValue("int");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a typo

@eolivelli eolivelli merged commit 44ba969 into master May 14, 2024
2 of 3 checks passed
@eolivelli eolivelli deleted the fix-metadata-cache-non-strings branch May 14, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eolivelli