Fix multiple field mappings conflict with each other, replacing own v…

…alue
datasprayio · Nov 30, 2024 · cb9eec5 · cb9eec5
1 parent 5c97226
commit cb9eec5
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/single-table/src/main/java/io/dataspray/singletable/ExpressionBuilder.java b/single-table/src/main/java/io/dataspray/singletable/ExpressionBuilder.java
@@ -210,9 +210,7 @@ public P delete(String fieldName, Object object) {
 
     @Override
     public String fieldMapping(String fieldName) {
-        String mappedName = "#" + sanitizeFieldMapping(fieldName);
-        nameMap.put(mappedName, fieldName);
-        return mappedName;
+        return fieldMapping(fieldName, fieldName);
     }
 
     @Override
@@ -225,6 +223,9 @@ public String fieldMapping(ImmutableList<String> fieldPath) {
     @Override
     public String fieldMapping(String fieldName, String fieldValue) {
         String mappedName = "#" + sanitizeFieldMapping(fieldName);
+        while (nameMap.containsKey(mappedName) && !nameMap.get(mappedName).equals(fieldName)) {
+            mappedName = mappedName + "_";
+        }
         nameMap.put(mappedName, fieldValue);
         return mappedName;
     }
@@ -238,6 +239,9 @@ public String valueMapping(String fieldName, Object object) {
     public String constantMapping(String name, Object object) {
         String mappedName = ":" + sanitizeFieldMapping(name);
         AttributeValue value = schema.toAttrValue(object);
+        while (valMap.containsKey(mappedName) && !valMap.get(mappedName).equals(value)) {
+            mappedName = mappedName + "_";
+        }
         valMap.put(mappedName, value);
         return mappedName;
     }