Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling for deleting expense #95

Open
oskstr opened this issue Sep 25, 2020 · 1 comment
Open

Improve error handling for deleting expense #95

oskstr opened this issue Sep 25, 2020 · 1 comment
Labels
bra första ärende Beginner friendly

Comments

@oskstr
Copy link
Member

oskstr commented Sep 25, 2020

I'm not sure what the best way to do this but it was brought to our attention yesterday that trying to delete an expense you're not allowed to delete would just result in a 500 status code. Probably better to at least have it return an unauthorized/forbidden code and some helpful page that shows what was wrong.

Should probably be done in many places.
@oskstr
Copy link
Member Author

oskstr commented Oct 9, 2020 •
edited
Loading

I tried to delete a duplicated expense. But I wasn't authorized to delete it. The button should probably not show up for me then. That would also solve this issue. may_delete -> show delete button

@foodelevator foodelevator added the bra första ärende Beginner friendly label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bra första ärende Beginner friendly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oskstr @foodelevator