Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFAL/Suggestion Controller - fetch values from facet results instead of indexable object #789

Open
milanmajchrak opened this issue Oct 16, 2024 · 0 comments · May be fixed by #835
Open
Assignees

Comments

@milanmajchrak
Copy link
Collaborator

milanmajchrak commented Oct 16, 2024

In the MetadataValueRestRepository and the SuggestionRestController the suggestion are fetched from the first 500 results. The final suggestions are fetched from those 500 results from the indexable object instead of using facet results.
TODO:

  1. Retrieve the suggestions from the facet results.
  2. Fix Authorization in the MetadataRestRepository findOne endpoint to @PreAuthorize("hasAuthority('AUTHENTICATED')")

https://github.com/dataquest-dev/DSpace/pull/768/files#diff-756458038536b83f459c0dcc52f55e1bae8598c30b7731a9290747b808625950R223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants