Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/EPIC PID service will never be called #404

Closed
milanmajchrak opened this issue Aug 9, 2023 · 1 comment · Fixed by #431
Closed

internal/EPIC PID service will never be called #404

milanmajchrak opened this issue Aug 9, 2023 · 1 comment · Fixed by #431
Assignees
@milanmajchrak
Labels
bug Something isn't working important

Comments

@milanmajchrak
Copy link
Collaborator

Problem description

It is allowed only Vanilla approach for creating handle: https://github.com/dataquest-dev/DSpace/blob/dtq-dev/dspace-api/src/main/java/org/dspace/handle/HandleServiceImpl.java#L146
@milanmajchrak milanmajchrak self-assigned this Aug 9, 2023
@milanmajchrak milanmajchrak changed the title internal/EPIC PID service will never called internal/EPIC PID service will never be called Aug 10, 2023
@milanmajchrak milanmajchrak added the bug Something isn't working label Aug 11, 2023
@milanmajchrak milanmajchrak linked a pull request Sep 6, 2023 that will close this issue
internal/epic-pid-service-never-called #431
Merged
@milanmajchrak
Copy link
Collaborator Author

milanmajchrak commented Sep 6, 2023 •
edited
Loading

I've solved more problems in this issue:

  1. CLARIN customization for composing custom handle following the community configuration was never called. Vanilla approach was used instead.
  2. The custom handle wasn't composed right. Prefix was missing.
  3. The community configuration wasn't properly loaded. It loaded one configuration for all custom handles.
  4. Tests was missing.
  5. After this updates some tests started to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milanmajchrak milanmajchrak

Labels
bug Something isn't working important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

internal/epic-pid-service-never-called dataquest-dev/DSpace
1 participant
@milanmajchrak