Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): clarify clean-up of indices when restoring search and graph indices #11380

Merged

Conversation

Masterchen09
Copy link
Contributor

@Masterchen09 Masterchen09 commented Sep 16, 2024

See acryldata/datahub-helm#475.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

  • Documentation
    • Updated instructions for restoring search and graph indices from the local database, clarifying the implications of not clearing existing indices.
    • Added details on using the datahub CLI for index restoration, emphasizing the need to clear indices to avoid inconsistencies.
    • Modified custom docker-compose deployment instructions to highlight potential issues with existing indices.
    • Included warnings in the Kubernetes section regarding service functionality during reindexing.

Copy link
Contributor

coderabbitai bot commented Sep 16, 2024

Walkthrough

The documentation for restoring search and graph indices from the local database has been updated to clarify the process and implications of not clearing existing documents. Key points include the behavior of the datahub CLI, modifications to custom docker-compose deployments, and Kubernetes job templates, all emphasizing potential inconsistencies during reindexing. Additional instructions for ensuring indices are cleared before restoration have been included, enhancing the overall clarity of the restoration process.

Changes

File Path Change Summary
docs/how/restore-indices.md Updated to clarify restoration process, added warnings about inconsistencies, modified docker-compose and Kubernetes instructions, and included details on clearing indices.

Suggested labels

merge-pending-ci

Poem

🐇 In the garden of code, changes bloom bright,
Restoring indices, a clear guiding light.
With warnings in place, we hop with glee,
Ensuring our data stays tidy and free!
So let’s clear the path, let the indices flow,
A seamless restore, watch our systems grow! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@RyanHolstien RyanHolstien merged commit 3fe39bc into datahub-project:master Sep 16, 2024
27 checks passed
@Masterchen09 Masterchen09 deleted the fix-docs-restore-indices branch September 17, 2024 07:04
Masterchen09 added a commit to Masterchen09/datahub that referenced this pull request Sep 17, 2024
@maggiehays
Copy link
Collaborator

@coderabbitai summary

sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community docs Issues and Improvements to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants