Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git tool missing from the ingestion-base image #11474

Closed
andor-pierdelacabeza opened this issue Sep 25, 2024 · 3 comments
Closed

git tool missing from the ingestion-base image #11474

andor-pierdelacabeza opened this issue Sep 25, 2024 · 3 comments
Labels
bug Bug report

Comments

@andor-pierdelacabeza
Copy link

Describe the bug
Since 2066f1f the git binary is missing from the datahub-ingestion-base images, making ingestions that import the gitpython module fail.

In 2066f1f the base image changed from python:3.10 to ubuntu:22.04. The Python image includes git, but the Ubuntu doesn't, so after upgrading to the latest 0.14 Datahub version ingestions started to fail.

  • datahub-actions image in versions 0.1.0 and 0.1.1 doesn't have git
    base image: acryldata/datahub-ingestion-base:2066f1f
  • datahub-actions image in version <=0.0.18 does have git
    base image: acryldata/datahub-ingestion-base:3903b17

Error message:

<class 'ImportError'>: Failed to initialize: Bad git executable. The git executable must be specified in one of the following ways: - be included in your $PATH - be set via $GIT_PYTHON_GIT_EXECUTABLE - explicitly set via git.refresh(<full-path-to-git-executable>) All git commands will error until this is rectified. This initial message can be silenced or aggravated in the future by setting the $GIT_PYTHON_REFRESH environment variable. Use one of the following values: - quiet|q|silence|s|silent|none|n|0: for no message or exception - warn|w|warning|log|l|1: for a warning message (logging level CRITICAL, displayed by default) - error|e|exception|raise|r|2: for a raised exception Example: export GIT_PYTHON_REFRESH=quiet

To Reproduce
Steps to reproduce the behavior:

  1. Get a Datahub deployment that uses a datahub-actions image with version >= 0.1.0
  2. create an ingest job that imports the gitpython module
  3. Run the job

Expected behavior
gitis available on the path

Screenshots

missinggit

@andor-pierdelacabeza
Copy link
Author

Nice, now the latest ingestion-base has git included... ❤️

@hsheth2 , maybe now a build of the datahub-actions image should be triggered so it builds on the new base?

@hsheth2
Copy link
Collaborator

hsheth2 commented Sep 28, 2024

@andor-pierdelacabeza yup - I just cut datahub-actions v0.1.2, which will have git in the image.

@hsheth2
Copy link
Collaborator

hsheth2 commented Oct 2, 2024

Now that acryldata/datahub-actions#134 is merged, the datahub-actions head tag should also have git.

@hsheth2 hsheth2 closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report
Projects
None yet
Development

No branches or pull requests

2 participants