Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road to v0.2 #154

Open
18 of 20 tasks
matthewmturner opened this issue Sep 20, 2024 · 7 comments
Open
18 of 20 tasks

Road to v0.2 #154

matthewmturner opened this issue Sep 20, 2024 · 7 comments

Comments

@matthewmturner
Copy link
Collaborator Author

@alamb let me know if there is anything you would like to add

@alamb
Copy link
Contributor

alamb commented Sep 21, 2024

I think we should consider adding #148 and #158 as well

@matthewmturner
Copy link
Collaborator Author

So I think it turns out that the DDL issue I have is a bug with datafusion registering external tables to a schema.

I have this in my ~/.datafusion/.datafusionrc`

CREATE SCHEMA staging;

CREATE TABLE staging.foo AS VALUES (1);
CREATE EXTERNAL TABLE staging.min_aggs STORED AS PARQUET LOCATION 'ny2://atlas/sip/aggregates/minute_by_ticker_monthly_v2/year_month=2015-08/data.01.parquet';

But when I run SHOW TABLES I get the following:

image

Notice how the schema isnt picked up for the the external table. I dont see anything in the docs for CREATE EXTERNAL TABLE that would suggest this shouldnt work but maybe im misunderstanding.

@alamb do you have a view on this? If you agree its a bug in datafusion then i can create a ticket there.

@alamb
Copy link
Contributor

alamb commented Sep 24, 2024

I agree it is a datafusion bug. I will file a ticket

@alamb
Copy link
Contributor

alamb commented Sep 24, 2024

Filed apache/datafusion#12607

@Kinrany
Copy link

Kinrany commented Dec 27, 2024

Is there anything that the current trunk version does worse than v0.1?

@matthewmturner
Copy link
Collaborator Author

@Kinrany i dont think so although i havent used v0.1 in a long time (years). i took a brief pause for december to work on some fun not work related project but im about to get back into dft in the beginning of the new year. im going to review where things are again and potentially do a release early on before proceeding to the next round of features i have in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants