Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] Streaming buffer size is not easily configurable #832

Open
ksafonov-db opened this issue Nov 25, 2024 · 0 comments
Open

[ISSUE] Streaming buffer size is not easily configurable #832

ksafonov-db opened this issue Nov 25, 2024 · 0 comments

Comments

@ksafonov-db
Copy link

Description

When downloading file contents, Files API initializes streaming buffer size = 1 Mb. This parameter is passed to requests library and then to underlying urllib3 code and controls the amount we're reading from the network stream. This parameter is not easily configurable by the user.

Reproduction

resp = client().files.download(path)
resp.contents.read()

Expected behavior

Client should be able to pass this parameter as a standard config option.
Internally, this config option will be the common source of truth for streaming buffer size.

Is it a regression?
No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant