Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add example raft-kv-memstore-opendal-snapshot-data #1018

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Feb 20, 2024

As title.

Checklist

  • Updated guide with pertinent info (may not always apply).
  • Squash down commits to one or two logical commits which clearly describe the work you've done.
  • Unittest is a friend:)

This change is Reviewable

@Xuanwo Xuanwo force-pushed the snapshot-on-opendal branch 3 times, most recently from 3eff687 to ff64a65 Compare February 20, 2024 09:40
@Xuanwo
Copy link
Member Author

Xuanwo commented Feb 20, 2024

cc @drmingdrmer, @schreter, would you like to take a review? Thanks!

@Xuanwo Xuanwo force-pushed the snapshot-on-opendal branch 2 times, most recently from f05cc1c to e889f72 Compare February 20, 2024 09:49
@drmingdrmer drmingdrmer self-requested a review February 20, 2024 10:14
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 14 files at r1, all commit messages.
Reviewable status: 9 of 14 files reviewed, 1 unresolved discussion (waiting on @Xuanwo)


examples/raft-kv-memstore-opendal-snapshot-data/README.md line 1 at r1 (raw file):

# Example Openraft kv-store with snapshot stored in remote storage

Explain why you create this example

@Xuanwo
Copy link
Member Author

Xuanwo commented Feb 20, 2024

The failure of examples (nightly, raft-kv-rocksdb) seems not related to this PR?

@drmingdrmer
Copy link
Member

The failure of examples (nightly, raft-kv-rocksdb) seems not related to this PR?

Right, it fails frequently. Ignore it.

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 14 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Xuanwo)

@drmingdrmer drmingdrmer merged commit c641db3 into databendlabs:main Feb 22, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants