-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict possible return types of _put
and _delete
methods
#28
Comments
👍 sounds like we should do that and verify that all backends do that (should be through |
|
This minimalkv/tests/basic_store.py Line 24 in e682c5c
could test new_key = store.put(key, value)
assert new_key == key We could do the same for |
deleteMost backends return
minimalkv/minimalkv/db/mongo.py Lines 32 to 33 in e682c5c
redis , which returns 1 if a file was deleted and 0 else:minimalkv/minimalkv/memory/redisstore.py Lines 27 to 28 in e682c5c
|
I forgot: Do we (want to) restrict the return types of
_put
and_delete
methods implemented by the backends? IIUC they generally return the key at which data was saved (or deleted).Originally posted by @mlondschien in #25 (comment)
The text was updated successfully, but these errors were encountered: