Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boto3 Store is untested code #10

Closed
siboehm opened this issue Apr 9, 2021 · 2 comments
Closed

Boto3 Store is untested code #10

siboehm opened this issue Apr 9, 2021 · 2 comments

Comments

@siboehm
Copy link
Contributor

siboehm commented Apr 9, 2021

In SimpleKV the Boto3 store was merged while the CI had been down for months: mbr/simplekv#106

So there was never a successful test-run on the CI. I spent an hour on it but couldn't figure out how to get it to connect to a Minio instance without bigger changes to the code. This is due to the client being created implicitly (contrary to explicitly like in the Boto store). I couldn't find a way to point the client to a local endpoint without modifying the global ~/.aws/config file.

The boto store still works, but the boto library hasn't seen any updates since 2018, so we should move to boto3 at some point definitely.

@simonbohnen
Copy link
Contributor

The tests for the Boto3Store are running, see e.g. here for failure vs here for passing tests.

@simonbohnen
Copy link
Contributor

@xhochy could you close this?

@xhochy xhochy closed this as completed Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants